Minimize API requests by skipping to check a given image ID #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/assign @prksu |
Save on API requests and stop querying for the image ID from the DO API if the numeric ID is already given: a failure to reference the image would show up during the droplet create request and lead to the same backoff that we run into today. Also refactor the code and improve error messages slightly as a drive-by change.
timoreimann
force-pushed
the
skip-checking-on-given-image-ids
branch
from
77dbc95 to
5bd6a23
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prksu, timoreimann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Save on API requests and stop querying for the image ID from the DO API if the numeric ID is already given: a failure to reference the image would show up during the droplet create request and lead to the same backoff that we run into today.
Special notes for your reviewer:
Also refactor the code and improve error messages slightly as a drive-by change.
Release note: