Skip to content

Move dns propagnation helpers to own packages #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2021
Merged

Move dns propagnation helpers to own packages #245

merged 2 commits into from
Mar 18, 2021

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Mar 16, 2021

What this PR does / why we need it:
This PR move DNS propagation helpers to own packages since cloud directory is devoted to related cloud provider stuff

Special notes for your reviewer:
/cc @gottwald
/assign @timoreimann

Release note:

None

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 16, 2021
@k8s-ci-robot
Copy link

@prksu: GitHub didn't allow me to request PR reviews from the following users: gottwald.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
This PR move DNS propagation helpers to own packages since cloud directory is devoted to related cloud provider stuff

Special notes for your reviewer:
/cc @gottwald
/assign @timoreimann

Release note:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2021
@prksu
Copy link
Contributor Author

prksu commented Mar 16, 2021

cc @gottwald

@prksu
Copy link
Contributor Author

prksu commented Mar 16, 2021

/cc @MorrisLaw @cpanato

@prksu
Copy link
Contributor Author

prksu commented Mar 16, 2021

/milestone v0.4

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Mar 16, 2021
gottwald
gottwald reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@gottwald gottwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, however the validation pattern of the "Name" should be extended.

@prksu prksu force-pushed the refactor-dns-utils branch from d44cc1e to c13fa01 Compare March 17, 2021 07:36
gottwald
gottwald approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@gottwald gottwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prksu prksu force-pushed the refactor-dns-utils branch from c13fa01 to 4d6a97e Compare March 18, 2021 07:19
cpanato
cpanato approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, gottwald, prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9c819d0 into kubernetes-sigs:master Mar 18, 2021
@prksu prksu deleted the refactor-dns-utils branch March 19, 2021 14:01
@gottwald gottwald mentioned this pull request Oct 27, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottwald gottwald gottwald approved these changes

@cpanato cpanato cpanato approved these changes

@MorrisLaw MorrisLaw Awaiting requested review from MorrisLaw

Assignees

@timoreimann timoreimann

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@prksu @k8s-ci-robot @gottwald @cpanato @timoreimann