Skip to content

[Clean Up] Refactor e2e test and update several dependencies #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2021
Merged

[Clean Up] Refactor e2e test and update several dependencies #244

merged 5 commits into from
Mar 15, 2021

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Mar 15, 2021

What this PR does / why we need it:

  • Update golang 1.13.15
  • Update capi v0.3.14
  • Refactor e2e test
  • Fix running e2e test on local machine due missing tools
  • Cleanup unused file

Special notes for your reviewer:

Documentation:

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from chuckha and detiber March 15, 2021 14:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2021
cpanato
cpanato reviewed Mar 15, 2021
View reviewed changes
cpanato
cpanato approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks for doing this cleanup, nice job

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8756303 into kubernetes-sigs:master Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Mar 15, 2021
@prksu prksu deleted the cleanup branch March 15, 2021 15:05
@prksu prksu restored the cleanup branch March 19, 2021 13:54
@prksu prksu deleted the cleanup branch March 19, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@chuckha chuckha Awaiting requested review from chuckha

@detiber detiber Awaiting requested review from detiber

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@prksu @k8s-ci-robot @cpanato