Skip to content

Omitempty ControlPlaneDNS #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2021
Merged

Omitempty ControlPlaneDNS #242

merged 1 commit into from
Mar 9, 2021

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Mar 9, 2021

What this PR does / why we need it:

This PR adds omitempty json tag to ControlPlaneDNS field. It's fine since ControlPlaneDNS is optional.

Special notes for your reviewer:

cc @gottwald

Documentation:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2021
gottwald
gottwald approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@gottwald gottwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpanato
cpanato approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, gottwald, prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2898086 into kubernetes-sigs:master Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Mar 9, 2021
@prksu prksu deleted the omitempty-controlplane-dns branch March 19, 2021 14:01
@gottwald gottwald mentioned this pull request Oct 27, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottwald gottwald gottwald approved these changes

@cpanato cpanato cpanato approved these changes

@detiber detiber Awaiting requested review from detiber

@timoreimann timoreimann Awaiting requested review from timoreimann

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@prksu @k8s-ci-robot @gottwald @cpanato