Skip to content

Update OWNERS #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2021
Merged

Update OWNERS #234

merged 2 commits into from
Feb 16, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 8, 2021

What this PR does / why we need it:

After discussing with other project maintainers, we have decided the following:

  • I'll be stepping down as a project maintainer
  • Promote Timo Reimann (@timoreimann) to a project maintainer

The lazy consensus for this change is 7 days from now, Monday, February 15th, 20:00 CET.

Release note:

NONE

cc @cpanato @MorrisLaw @prksu @timoreimann

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Feb 8, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
cpanato
cpanato approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Marko for all your work on this project!
welcome Timo

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021
@timoreimann
Copy link
Contributor

Very excited to be joining you soon as a maintainer! 🎉

prksu
prksu approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@prksu prksu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xmudrii I think the lazy consensus is over. Thanks for all your amazing work 🙇🏻
And congrats @timoreimann 🎉

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, prksu, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,prksu,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Feb 16, 2021

@prksu That's right, the lazy consensus is now over. 🙂

Welcome to the team @timoreimann! 🎉

I'll create PRs to update OWNERS in other places later today.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit deb5e64 into kubernetes-sigs:master Feb 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Feb 16, 2021
@xmudrii xmudrii deleted the update-owners branch February 16, 2021 12:40
@timoreimann
Copy link
Contributor

🎉 thrilled to be joining this fine bunch of folks. 😄

@xmudrii thanks for your all hard work in CAPDO, truly appreciated 💙

This was referenced Feb 17, 2021
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@prksu prksu prksu approved these changes

@chuckha chuckha Awaiting requested review from chuckha

@detiber detiber Awaiting requested review from detiber

Assignees

@cpanato cpanato

@prksu prksu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xmudrii @timoreimann @k8s-ci-robot @cpanato @prksu