-
Notifications
You must be signed in to change notification settings - Fork 50
Add external storage support for etcd #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external storage support for etcd #228
Conversation
Welcome @gottwald! |
Hi @gottwald. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This allows DOMachines to be provisioned with attached block storage volumes. The current implemenation does not support resizing disks. This will be added as a follow-up.
922d077
to
0c2f442
Compare
/ok-to-test |
@timoreimann: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Left a few comments.
/ok-to-test |
/assign I'll take a look into this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gottwald, thanks for tackling this one. My apologize for long delay.
I left some comment
@prksu PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already tested and all functionality is good. let's add the e2e test for this feature as the follow up.
thanks, @gottwald !!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gottwald, prksu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This adds DataDisks support for DOMachines which can be used to host etcd data on block storage volumes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #197
Special notes for your reviewer:
This does not include resizing support. Should be followed up by another PR to introduce it.
Release note: