Skip to content

Update doc for v0.4 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2020
Merged

Update doc for v0.4 #224

merged 1 commit into from
Dec 22, 2020

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Dec 11, 2020 •
edited
Loading

What this PR does / why we need it:

  • Update compatibility matrix in README
  • Update getting-started guide based on clusterctl
    The legacy getting-started guide should still work under release-0.3 branch

Special notes for your reviewer:

Documentation:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 11, 2020
MorrisLaw
MorrisLaw reviewed Dec 14, 2020
View reviewed changes
cpanato
cpanato reviewed Dec 16, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prksu can you address Jeremy's comment?

@prksu
Copy link
Contributor Author

prksu commented Dec 19, 2020

@MorrisLaw addressed your comment, please take another look. thanks!

cpanato
cpanato approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for @MorrisLaw review as well

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2020
MorrisLaw
MorrisLaw requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@MorrisLaw MorrisLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more grammatical nits then I think we are good.

Great work @prksu!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2020
@prksu
Copy link
Contributor Author

prksu commented Dec 22, 2020

@MorrisLaw updated regarding your review. ptal
thanks!!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, MorrisLaw, prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MorrisLaw,cpanato,prksu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MorrisLaw
Copy link
Member

Thanks for your hard work @prksu

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2020
@MorrisLaw MorrisLaw removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit fe6cb6d into kubernetes-sigs:master Dec 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Dec 22, 2020
@timoreimann timoreimann mentioned this pull request Jan 25, 2021
Merged
@prksu prksu deleted the update-docs branch January 26, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@MorrisLaw MorrisLaw MorrisLaw approved these changes

Assignees

@cpanato cpanato

@MorrisLaw MorrisLaw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@prksu @k8s-ci-robot @MorrisLaw @cpanato