-
Notifications
You must be signed in to change notification settings - Fork 50
Do not mark droplet create failures as terminal #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not mark droplet create failures as terminal #215
Conversation
Hi @timoreimann. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch and follow up with a fix! I also appreciate the description, in slack, for why this should be fixed.
/lgtm
/hold for @prksu final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just tried on my machine, there is one thing that is missing is user experience
This allows to address transient errors through automatic reconciles.
6e038fd
to
938abed
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MorrisLaw, prksu, timoreimann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows to address transient errors through automatic reconciles.
What this PR does / why we need it:
Do not mark droplet create failures as terminal.
This allows to address transient errors through automatic reconciles.
Which issue(s) this PR fixes:
Fixes #214
Release note: