janitor: add code to clean the DO account for capdo #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
timoreimann
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
Nice work, thanks @cpanato. 👏
(I have no approval powers here but thought I could give my 2 cents anyway. :) )
|
@prksu should we extract that to some utils package? and then both uses that? |
k8s-ci-robot
added
size/M
xmudrii
reviewed
Dec 7, 2020
k8s-ci-robot
added
size/L
k8s-ci-robot
added
do-not-merge/hold
xmudrii
approved these changes
Dec 7, 2020
k8s-ci-robot
added
lgtm
xmudrii
approved these changes
Dec 7, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, timoreimann, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
prksu
pushed a commit
to prksu/cluster-api-provider-digitalocean
that referenced
this pull request
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add go code to clean up resources in the CAPDO DO Account that is older than 2 days to avoid account limits and spend $ for nothing.
I will add a periodic job in prow to run every day
/kind feature
/assign @MorrisLaw @prksu @xmudrii
mention @timoreimann as well to be aware :)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Documentation:
Release note: