-
Notifications
You must be signed in to change notification settings - Fork 448
Allow users to set the zone for NAT gateway #5738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @rna-afk! |
Hi @rna-afk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5738 +/- ##
==========================================
- Coverage 52.84% 52.84% -0.01%
==========================================
Files 278 278
Lines 29610 29612 +2
==========================================
Hits 15647 15647
- Misses 13146 13148 +2
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Allow users to set the zone they need the created NAT gateway to use. ASO allows the NAT gateway to be set to a zone so enabling that here.
e1a9d1c
to
359ba16
Compare
/retest |
Allow users to set the zone they need the created
NAT gateway to use. ASO allows the NAT gateway to
be set to a zone so enabling that here.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Special notes for your reviewer:
TODOs:
Release note: