compiler-rt: fix do_install error #1071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After commit * 6da0aba clang.bbclass,compiler-rt: Do not set -target for native clang it installs files to ${nonarch_libdir}/linux rather than ${libdir}/linux when multilib enabled. Update to fix following do_install error: mv: cannot stat '/path_to/tmp/work/core2-64-poky-linux/compiler-rt/20.1.1/image/usr/lib64/linux': No such file or directory Signed-off-by: Kai Kang <[email protected]>
kraj
approved these changes
Mar 31, 2025
|
What about removing the whole conditional? That's what I was using with #1072 |
shr-project
reviewed
Apr 1, 2025
| mv ${D}${libdir}/linux ${D}${nonarch_libdir}/clang/${MAJOR_VER}.${MINOR_VER}.${PATCH_VER}/lib | ||
| rmdir --ignore-fail-on-non-empty ${D}${libdir} | ||
| mv ${D}${nonarch_libdir}/linux ${D}${nonarch_libdir}/clang/${MAJOR_VER}.${MINOR_VER}.${PATCH_VER}/lib | ||
| rmdir --ignore-fail-on-non-empty ${D}${nonarch_libdir} |
There was a problem hiding this comment.
This one be ever empty as you've used it in above line, right? It was useful only for cases where libdir and nonarch_libdir weren't the same to remove now empty libdir after everything was moved to nonarch_libdir.
I think this whole conditional isn't needed as LLVM_LIBDIR_SUFFIX isn't empty only when libdir and nonarch_libdir aren't the same directory.
And when they are the same than we can use nonarch_libdir in both cases.
yeah thats perhaps better to do. |
|
fixed with #1072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit
it installs files to ${nonarch_libdir}/linux rather than ${libdir}/linux when multilib enabled. Update to fix following do_install error:
mv: cannot stat '/path_to/tmp/work/core2-64-poky-linux/compiler-rt/20.1.1/image/usr/lib64/linux': No such file or directory
Contributor checklist
Signed-off-byis presentReviewer Guidelines