Skip to content

gimp: Remove -Qunused-arguments from complier cmdline with clang #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

kraj
Copy link
Owner

@kraj kraj commented Mar 28, 2025

This supresses the -msseX argument diagnostics on non-x86 architectures and meson wrongly decided to enable SSE on these biulds which ends up in

│| In file included from ../gimp-3.0.2/app/gegl/gimp-gegl-loops-sse2.c:36: │
│| /mnt/b/yoe/master/build/tmp/work/riscv64-yoe-linux/gimp/3.0.2/recipe-sysroot-native/usr/lib/clang/20/include/emmintrin.h:14:2: error: "This header is only meant to be used on x86 and│
│ x64 architecture" │
│| 14 | #error "This header is only meant to be used on x86 and x64 architecture" │
│| | ^ │
│| In file included from ../gimp-3.0.2/app/gegl/gimp-gegl-loops-sse2.c:36:


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

This supresses the -msseX argument diagnostics on non-x86 architectures
and meson wrongly decided to enable SSE on these biulds which ends up in

                                   │
│| In file included from ../gimp-3.0.2/app/gegl/gimp-gegl-loops-sse2.c:36:                                                                                                               │
│| /mnt/b/yoe/master/build/tmp/work/riscv64-yoe-linux/gimp/3.0.2/recipe-sysroot-native/usr/lib/clang/20/include/emmintrin.h:14:2: error: "This header is only meant to be used on x86 and│
│ x64 architecture"                                                                                                                                                                      │
│|    14 | #error "This header is only meant to be used on x86 and x64 architecture"                                                                                                     │
│|       |  ^                                                                                                                                                                            │
│| In file included from ../gimp-3.0.2/app/gegl/gimp-gegl-loops-sse2.c:36:

Signed-off-by: Khem Raj <[email protected]>
@kraj kraj merged commit 8923801 into kraj:master Mar 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant