Skip to content

clang: Disable building dexp in clang-native #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

ycongal-smile
Copy link
Contributor

@ycongal-smile ycongal-smile commented Mar 25, 2025

Building dexp (native) on Debian 11 causes intermittent failure0. This tools in not used in clang except in tests (that we don't run).

So, disable building this tool by encapsulating its build in a cmake option and then in a PACKAGECONFIG.

Users sure of not using Debian 11 (or the impacted g++ compiler) can turn this config on safely.

Only the -native* variants change. Dexp is still enabled by default for target.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@ycongal-smile ycongal-smile marked this pull request as ready for review March 26, 2025 00:00
@ycongal-smile ycongal-smile requested a review from kraj as a code owner March 26, 2025 00:00
@ycongal-smile
Copy link
Contributor Author

v2:

  • rename the PACKAGECONFIG to clang-dexp to make the dependency to clangd clear.
  • Don't try to enable it on target variant since clangd is disabled.

@ycongal-smile
Copy link
Contributor Author

V3: update patch status and message to match the submitted PR: llvm/llvm-project#133124

Building dexp (native) on Debian 11 causes intermittent failure[0].
This tools in not used in clang except in tests (that we don't run).

So, disable building this tool by encapsulating its build in a cmake
option and then in a PACKAGECONFIG.

Users sure of not using Debian 11 (or the impacted g++ compiler) can
turn this config on safely.

Only the -native* variants change. Dexp is still enabled by default for
target.

[0]: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15803

Signed-off-by: Yoann Congal <[email protected]>
@ycongal-smile
Copy link
Contributor Author

v4: updated patch following results of the LLVM/CLANG CI. (Error only impacted the upstream tests)

@kraj kraj merged commit fa1b780 into kraj:master Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants