drop internal xxhash copy #623
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious: why ? for neatiness, or because you plan to use it for other stuff, and which ? |
benoit-pierre
force-pushed
the
pr/drop_internal_xxhash_copy
branch
from
c37efb2 to
2d16765
Compare
|
Fine with me. Tell me when you're done and need to have it merged for bump. |
In favour of a thirdparty library available to all projects.
benoit-pierre
force-pushed
the
pr/drop_internal_xxhash_copy
branch
from
2d16765 to
2518c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favour of a thirdparty library available to all projects.
This change is