Skip to content

drop internal xxhash copy #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Jul 12, 2025

In favour of a thirdparty library available to all projects.


This change is Reviewable

@poire-z
Copy link
Contributor

poire-z commented Jul 12, 2025

Just curious: why ? for neatiness, or because you plan to use it for other stuff, and which ?

@benoit-pierre
Copy link
Contributor Author

For koreader/koreader-base#2113.

@benoit-pierre benoit-pierre force-pushed the pr/drop_internal_xxhash_copy branch from c37efb2 to 2d16765 Compare July 12, 2025 22:40
@poire-z
Copy link
Contributor

poire-z commented Jul 13, 2025

Fine with me. Tell me when you're done and need to have it merged for bump.

In favour of a thirdparty library available to all projects.
@benoit-pierre benoit-pierre force-pushed the pr/drop_internal_xxhash_copy branch from 2d16765 to 2518c33 Compare July 20, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants