Add Unmanaged to scratch View in TeamPolicy example
#699
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholladay00
reviewed
Jul 21, 2025
| @@ -168,7 +168,7 @@ Examples | |||
| int scan = team_handle.team_scan(tid+1, &global); | |||
| // scan == tid*(tid+1)/2 on every thread | |||
| // global == ts*(ts-1)/2 on every thread | |||
| Kokkos::View<int*, policy_type::execution_space::scratch_memory_type> | |||
| Kokkos::View<int*, policy_type::execution_space::scratch_memory_type, Kokkos::MemoryTraits<Kokkos::Unmanaged>> | |||
There was a problem hiding this comment.
Just to note that I couldn't find any reference to a scratch_memory_type alias in recent versions of the code.
There was a problem hiding this comment.
yeah, grep shows no hits ... I will change to scratch_memory_space
Of course, that's not required to create an unmanaged View. The example would also work without it. |
Co-authored-by: Daniel Arndt <[email protected]>
Co-authored-by: Daniel Arndt <[email protected]>
masterleinad
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a discussion with @dalg24 and @dholladay00 on slack.
The
Unmanagedtrait seems to be missing in the view allocation in the example. This PR also adds a hint on theScratchMemorySpacerequiringUnmanaged