Skip to content

proposal for ipsec e2e test #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

xiaojiangao123
Copy link

@xiaojiangao123 xiaojiangao123 commented May 15, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The lack of end-to-end (e2e) testing for the IPsec functionality and offload Authorization in Kmesh.

Does this PR introduce a user-facing change?:
NONE

@Copilot Copilot AI review requested due to automatic review settings May 15, 2025 04:04
@kmesh-bot
Copy link
Collaborator

@xiaojiangao123: The label(s) kind/documentation cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The lack of end-to-end (e2e) testing for the IPsec functionality in Kmesh.

Does this PR introduce a user-facing change?:
NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kmesh-bot
Copy link
Collaborator

Welcome @xiaojiangao123! It looks like this is your first PR to kmesh-net/kmesh 🎉

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR proposes adding documentation for developing end-to-end tests for the IPsec functionality in Kmesh, detailing test scenarios and environment requirements.

  • Introduces a new IPsec E2E testing proposal document in Chinese.
  • Outlines three core test scenarios: basic connectivity, key update, and failure recovery.
  • Specifies the test environment requirements and includes detailed testing steps.

@LiZhenCheng9527
Copy link
Contributor

Can you tell us about your thinking at this week's meeting?

Copy link
Contributor

@LiZhenCheng9527 LiZhenCheng9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add the results that each test expects.


###### 测试步骤

- 在不同节点部署httpbin和sleep应用
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to redeploy sleep and httpbin every step?

@@ -0,0 +1,113 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI:

Design doc of Kmesh E2E framework: https://github.com/kmesh-net/kmesh/blob/main/docs/proposal/e2e.md

User guide: https://kmesh.net/en/docs/developer/e2e-guide/

and all test cases should be added in https://github.com/kmesh-net/kmesh/tree/main/test/e2e

You can write new test cases based on existing ones.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also English doc is prefered

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment



#### 3. Offload Authorization Test Scenarios
Apply the corresponding security policies (ALLOW/DENY) and routing strategies, and verify connectivity. Tests can be conducted at workload, namespace, and global scopes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offload Authorization only support port and IP address.
The remaining Authorization types are handled in user space.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the project description of OSPP, there is a requirement for E2E testing excluding IP and port authentication.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Kmesh supports these types of Authorization through offload authorization and user space Authorization.
Just a note that there is a difference between offload Authorization and User space Authorization in Kmesh's Authorization.

@LiZhenCheng9527
Copy link
Contributor

If you want to do this project, go to #1408 and leave a comment under it to let people know you are doing something on it. The mentor will assign you when he is sure.

@LiZhenCheng9527 LiZhenCheng9527 added the documentation Improvements or additions to documentation label May 29, 2025
@kmesh-bot
Copy link
Collaborator

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/contains-merge-commits documentation Improvements or additions to documentation size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants