Skip to content

svelte-cookie-banner.js.org #9934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

svelte-cookie-banner.js.org #9934

merged 1 commit into from
Jul 8, 2025

Conversation

SebaOfficial
Copy link
Contributor

@SebaOfficial SebaOfficial commented Jul 8, 2025

The site content is the documentation + demo of a npm package that simplifies cookies management on the frontend (Available at npm: https://www.npmjs.com/package/svelte-cookie-banner)

@MattIPv4 MattIPv4 changed the title Update cnamesj svelte-cookie-banner.js.org Jul 8, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jul 8, 2025
@SebaOfficial SebaOfficial requested a review from MattIPv4 July 8, 2025 13:31
@MattIPv4
Copy link
Member

MattIPv4 commented Jul 8, 2025

Hm, https://sebaofficial.github.io/svelte-cookie-banner/ still isn't redirecting to the JS.org subdomain, which I'd expect if you have configured the custom subdomain for the GitHub Pages site.

@SebaOfficial
Copy link
Contributor Author

Hm, https://sebaofficial.github.io/svelte-cookie-banner/ still isn't redirecting to the JS.org subdomain, which I'd expect if you have configured the custom subdomain for the GitHub Pages site.

Could it be cache?
image

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 8, 2025

Looks like you just pushed a fix 👍

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/SebaOfficial/svelte-cookie-banner

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Jul 8, 2025
@indus
Copy link
Member

indus commented Jul 8, 2025

Welcome https://svelte-cookie-banner.js.org

@indus indus merged commit c91f91b into js-org:master Jul 8, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants