Skip to content

open-api.js.org #9929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

open-api.js.org #9929

merged 2 commits into from
Jul 7, 2025

Conversation

harys722
Copy link
Contributor

@harys722 harys722 commented Jul 6, 2025

The site content is ...
My website is related as the JavaScript API documentation. It is actually the documentation site of my APIs that are purely created in JavaScript. This project is open source and can be seen in Open APIs GitHub repository.

@indus indus changed the title Registering 'open-apis' subdomain open-apis.js.org Jul 6, 2025
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Jul 6, 2025
@indus
Copy link
Member

indus commented Jul 6, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@harys722
Copy link
Contributor Author

harys722 commented Jul 6, 2025

Hey, @indus I used GitHub workflow to automate the commits but the site is deployed using the branch, not workflow. So I didn't face any issues.

https://open-apis.js.org/ is now live! :)

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jul 6, 2025
@indus
Copy link
Member

indus commented Jul 6, 2025

@harys722 It is good to hear it works but you have to restore the PR as it is not yet merged (other wise I will have to remove the subdomain)

@indus indus added the awaiting response This PR is waiting for a response from the requester label Jul 6, 2025
@harys722
Copy link
Contributor Author

harys722 commented Jul 7, 2025

you have to restore the PR as it is not yet merged (other wise I will have to remove the subdomain)

May you elaborate more? Also I would like to change the subdomain to open-apis.

- open-apis
+ open-api

@indus
Copy link
Member

indus commented Jul 7, 2025

you have to restore the PR as it is not yet merged (other wise I will have to remove the subdomain)

May you elaborate more? Also I would like to change the subdomain to open-apis.

- open-apis
+ open-api

Hm - for some reason I had the impression that you had removed the code-change which would have left me with nothing to merge. But it looks like that is not the case and I was wrong.
Nevertheless if you now want open-api you have to change the pull-request accordingly. You also have to fix the alphabetical order: https://github.com/js-org/js.org/actions/runs/16101795020/job/45431920935?pr=9929

@indus indus added invalid and removed awaiting response This PR is waiting for a response from the requester labels Jul 7, 2025
@harys722
Copy link
Contributor Author

harys722 commented Jul 7, 2025

You also have to fix the alphabetical order: https://github.com/js-org/js.org/actions/runs/16101795020/job/45431920935?pr=9929

I remember I added my subdomain accordingly, I'll check it again. Not sure what's the actual issue.

@harys722
Copy link
Contributor Author

harys722 commented Jul 7, 2025

Alright, now it should be fine.

@indus indus changed the title open-apis.js.org open-api.js.org Jul 7, 2025
@indus
Copy link
Member

indus commented Jul 7, 2025

CI-checks look fine now.
I've already just changed the subdomain in JS.ORGs zonefile to open-api. You now have to change the CNAME on your side as well.
I'll merge after we have "contact". Please keep this PR open.

@indus indus added awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed invalid labels Jul 7, 2025
@harys722
Copy link
Contributor Author

harys722 commented Jul 7, 2025

I've updated the custom domain in GitHub pages and also created the CNAME file in pages directory. 👍

@harys722
Copy link
Contributor Author

harys722 commented Jul 7, 2025

I have a question, if I change the GitHub repository name in future somehow, will I need to change the harys722.github.io/open-apis here too?

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jul 7, 2025
@indus
Copy link
Member

indus commented Jul 7, 2025

Welcome https://open-api.js.org

I have a question, if I change the GitHub repository name in future somehow, will I need to change the harys722.github.io/open-apis here too?

Yes

@indus indus merged commit 100a279 into js-org:master Jul 7, 2025
2 of 4 checks passed
@harys722 harys722 deleted the patch-1 branch July 7, 2025 13:32
@harys722
Copy link
Contributor Author

harys722 commented Jul 7, 2025

Yes

Alright.

Nice. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants