Fix #1051: Replace lru_cache with TTL-based key caching #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1051 where PyJWKClient with
cache_keys=True
serves potentially revoked keys indefinitely.Problem
When
cache_keys=True
is enabled, PyJWKClient applies@lru_cache
to theget_signing_key
method. This caches keys permanently until LRU eviction or process restart. If an identity provider removes a key from their JWKS, applications continue accepting tokens signed with that key.Solution
lru_cache
with TTL-aware cachinglifespan
(default 300 seconds)Changes
Testing
All existing tests pass. New test verifies that:
Backward Compatibility
No breaking changes. All existing parameters work identically:
cache_keys=True
still enables individual key cachingmax_cached_keys
still limits cache sizeFixes #1051