Skip to content

Removed redundant args in _encode_payload method #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KrishnenduDG
Copy link

Well, was just going through the basic implementation of the whole jwt flow. Just then I realised that there was an extra and unused argument headers being passed in the _encode_payload method. Removed that from both the function definition and the function call.

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we verify this change?

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label May 19, 2025
@github-actions github-actions bot closed this May 27, 2025
@auvipy auvipy reopened this May 27, 2025
@auvipy auvipy requested review from jpadilla, jtemporal and Copilot May 27, 2025 07:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Clean up the _encode_payload method by removing an unused headers parameter from its signature and call site.

  • Removed the redundant headers argument from the internal payload encoding method.
  • Updated the call to _encode_payload to no longer pass headers.
Comments suppressed due to low confidence (1)

jwt/api_jwt.py:149

  • Update the docstring of _encode_payload to remove any references to the now-removed headers parameter so the documentation matches the signature.
"""

@github-actions github-actions bot removed the stale Issues without activity for more than 60 days label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants