Making passport compatible with graphql #542
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So, in this commit I've enabled returning a value from the authenticate method of any strategy.
I've tested it with this strategy passport-graphql-mongoose that returns a promise instead of depending on callbacks.
I had to do this because if the authentication method is asynchronous, I always get an empty result and the callback takes effect only later on.
Now I can do something like this:
regards,
Mostafa