Skip to content

Cache for AssemblyDataProvider #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/AssemblyLoader/Services/AssemblyDataProvider.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
using System.Diagnostics;
using System;
using System.Collections.Concurrent;
using System.Diagnostics;
using System.Reflection;
using System.Threading.Tasks;
using BlazorLazyLoading.Abstractions;
using BlazorLazyLoading.Comparers;
using BlazorLazyLoading.Models;

namespace BlazorLazyLoading.Services
Expand All @@ -11,24 +14,36 @@ public sealed class AssemblyDataProvider : IAssemblyDataProvider
private readonly IAssemblyDataLocator _assemblyDataLocator;
private readonly IContentFileReader _contentFileReader;

private readonly ConcurrentDictionary<AssemblyName, AssemblyData?> _assemblyDataCache;

public AssemblyDataProvider(
IAssemblyDataLocator assemblyDataLocator,
IContentFileReader contentFileReader)
{
_assemblyDataLocator = assemblyDataLocator;
_contentFileReader = contentFileReader;
_assemblyDataCache = new ConcurrentDictionary<AssemblyName, AssemblyData?>(AssemblyByNameAndVersionComparer.Default);
}

public async Task<AssemblyData?> GetAssemblyDataAsync(AssemblyName assemblyName, AssemblyLoaderContext context)
public async Task<AssemblyData?> GetAssemblyDataAsync(
AssemblyName assemblyName,
AssemblyLoaderContext context)
{
if (_assemblyDataCache.TryGetValue(assemblyName, out AssemblyData? data))
{
return data;
}

var paths = _assemblyDataLocator.GetFindPaths(assemblyName, context);

foreach (var path in paths)
{
AssemblyData? data = await GetAssemblyDataAsync(assemblyName, path).ConfigureAwait(false);
data = await GetAssemblyDataAsync(assemblyName, path).ConfigureAwait(false);

if (data != null)
{
_assemblyDataCache.TryAdd(assemblyName, data);

return data;
}
}
Expand Down