Fix mission file save error caused by fs module usage #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the "fs is not defined" ReferenceError when saving mission files from the Mission Control tab. **Problem:** - Legacy code was using Node.js fs.writeFile() directly from renderer - fs module is not accessible in Electron's renderer process - Users got error: "ReferenceError: fs is not defined" at line 4050 **Solution:** - Replace fs.writeFile() with window.electronAPI.writeFile() - Use Promise-based API (.then) instead of callback pattern - Move success messages inside .then() block to ensure they execute after file write completes **Testing:** - Configurator builds without errors - Mission file save dialog opens correctly - Files save successfully to selected location - No console errors Follows the same pattern used in cli.js and other tabs.
Collaborator
|
I tested this with Windows. When the 'save eeprom mission' button is pressed, the tab will go blank and then reappear with the mission WP's gone. I also noticed that other 9.0 builds before this fix will also work once a mission is saved via this build. i.e. before the PC is shutdown and cache is dumped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "fs is not defined" ReferenceError that occurs when trying to save mission files from the Mission Control tab.
Problem
Users encountered a JavaScript error when attempting to save mission files:
The legacy code was using Node.js
fs.writeFile()directly from the renderer process, but thefsmodule is not accessible in Electron's renderer process due to context isolation.Changes
fs.writeFile()withwindow.electronAPI.writeFile().then()).then()block to ensure they execute after file write completesTesting
This follows the same pattern already used in
cli.jsand other tabs that were previously updated.