bring maintenance-10.x up to date with Maintenance 9.x

.github/workflows/pr-branch-suggestion.yml

@@ -0,0 +1,37 @@
+name: PR Branch Suggestion
+
+on:
+  pull_request_target:
+    types: [opened]
+    branches:
+      - master
+
+jobs:
+  suggest-branch:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Suggest maintenance branch
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const comment = `### Branch Targeting Suggestion
+
+            You've targeted the \`master\` branch with this PR. Please consider if a version branch might be more appropriate:
+
+            - **\`maintenance-9.x\`** - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.
+
+            - **\`maintenance-10.x\`** - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x
+
+            If \`master\` is the correct target for this change, no action is needed.
+
+            ---
+            *This is an automated suggestion to help route contributions to the appropriate branch.*`;
+
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: comment
+            });

CLAUDE.md

@@ -0,0 +1,128 @@
+# INAV Configurator - Developer Guide
+
+> **Maintainers:** Update this file when making architectural changes or adding major features.
+
+## Overview
+
+INAV Configurator is a cross-platform Electron desktop application for configuring INAV flight controllers. It supports multirotors, fixed-wing aircraft, rovers, and boats.
+
+**Tech Stack:** Electron + Vite + jQuery + i18next
+
+## Quick Start
+
+```bash
+yarn install    # Install dependencies
+yarn start      # Run in development mode (hot reload)
+yarn make       # Build distributable packages
+```
+
+## Directory Structure
+
+```
+inav-configurator/
+├── js/                     # Main application source
+│   ├── configurator_main.js    # Renderer entry point (initializes UI)
+│   ├── fc.js                   # Flight controller state model
+│   ├── gui.js                  # Tab switching & UI management
+│   ├── msp.js                  # MSP protocol encoder/decoder
+│   ├── serial_backend.js       # Connection orchestration
+│   ├── main/                   # Electron main process
+│   │   ├── main.js                 # Main process entry
+│   │   └── preload.js              # IPC bridge (renderer↔main)
+│   ├── connection/             # Connection layer (factory pattern)
+│   │   ├── connectionSerial.js     # Serial port
+│   │   ├── connectionTcp.js        # TCP/IP (SITL)
+│   │   └── connectionBle.js        # Bluetooth LE
+│   ├── msp/                    # MSP protocol helpers
+│   │   ├── MSPCodes.js             # Command codes
+│   │   └── MSPHelper.js            # Serialization (largest file)
+│   └── transpiler/             # Logic conditions compiler
+├── src/css/                # Stylesheets
+│   └── tabs/                   # Per-tab styles
+├── locale/                 # i18n translations (en, ja, ru, uk, zh_CN)
+├── resources/              # 3D models, OSD fonts, SITL binaries
+├── index.html              # Single-page app entry
+├── forge.config.js         # Electron Forge build config
+└── vite.*.config.js        # Vite build configs
+```
+
+## Architecture
+
+### Data Flow
+
+```
+User → GUI Tab → MSP.send_message() → Serial Queue → Connection → Flight Controller
+                                                                         ↓
+User ← GUI Update ← FC state object ← MSP.decode() ← Serial Data ←──────┘
+```
+
+### Key Subsystems
+
+1. **Connection Layer** (`js/connection/`): Factory pattern abstracts serial, TCP, UDP, BLE
+2. **MSP Protocol** (`js/msp/`): Binary protocol for FC communication (V1/V2 variants)
+3. **FC State** (`js/fc.js`): Central state object (CONFIG, PID, SENSOR_DATA, GPS_DATA, etc.)
+4. **Tab System** (`js/gui.js`): Tabs load dynamically; separate tabs for connected vs disconnected states
+
+### MSP Request Pattern
+
+```javascript
+MSP.send_message(MSPCodes.MSP_SOME_CODE, payload, false, () => {
+    // FC state already updated, refresh UI here
+    updateUIFromState(FC.SOME_DATA);
+});
+```
+
+## Adding a New Tab
+
+1. Create tab JS file with `initialize()` and `cleanup()` functions
+2. Register in `TABS` object
+3. Add CSS in `src/css/tabs/`
+4. Add HTML link in `index.html` (mode-connected or mode-disconnected list)
+5. Add translation keys to `locale/en/messages.json`
+
+## Adding New MSP Commands
+
+1. Add command code to `js/msp/MSPCodes.js`
+2. Add serialize/deserialize logic to `js/msp/MSPHelper.js`
+3. Add state property to `js/fc.js`
+4. Use in relevant tab
+
+## Build Targets
+
+| Platform | Command | Output |
+|----------|---------|--------|
+| Windows  | `yarn make --platform win32` | MSI installer |
+| macOS    | `yarn make --platform darwin` | DMG |
+| Linux    | `yarn make --platform linux` | DEB, RPM |
+
+## Key Files by Importance
+
+| File | Purpose |
+|------|---------|
+| `js/msp/MSPHelper.js` | All MSP serialization (159KB - largest file) |
+| `js/fc.js` | Flight controller state model |
+| `js/serial_backend.js` | Connection management |
+| `js/gui.js` | Tab switching, UI state |
+| `js/configurator_main.js` | Application initialization |
+
+
+## Code Patterns
+
+- **jQuery** for DOM manipulation
+- **Callbacks** for async (some Promises)
+- **i18next** via `data-i18n` attributes: `<span data-i18n="key"></span>`
+- **ES6 modules** throughout (`import`/`export`)
+
+## Debugging
+
+```bash
+NODE_ENV=development yarn start   # Dev mode
+# Press Ctrl+Shift+I for DevTools
+```
+
+## Resources
+
+- [INAV Firmware](https://github.com/iNavFlight/inav)
+- [INAV Wiki](https://github.com/iNavFlight/inav/wiki)
+- [INAV Discord](https://discord.gg/peg2hhbYwN)
+- [Electron Docs](https://www.electronjs.org/docs)

README.md

@@ -113,11 +113,21 @@ Example (note the double -- ):
 To be able to open Inspector, set environment variable `NODE_ENV` to `development` or set the flag directly when run `npm start`:
 
 ```NODE_ENV=development npm start``` or ```$env:NODE_ENV="development" | npm start``` for Windows PowerShell
+Chrome Devtools will be available on http://localhost:9222. This can also be used with an MCP plugin
 
 Or use VScode and start a debug session `Debug Configurator` (Just hit F5!)
 
 To debug the main thread (source files in `js/main`), just set a breakpoint in VScode.
 
+
+To capture a debug log from a packaged version (such as from a user), they can run it as:
+```.\inav-configurator.exe --enable-logging --log-file=inav-log.txt```
+or to log to the console:
+```.\inav-configurator.exe --enable-logging --log-file=inav-log.txt```
+
+
+
+
 ## Different map providers
 
 INAV Configurator allows you to choose between OpenStreetMap, Esri World Imagery (Aerial View), and MapProxy map providers.

forge.config.js

@@ -9,6 +9,9 @@ export default {
     executableName: "inav-configurator",
     asar: false,
     icon: 'images/inav',
+    extraResource: [
+      'resources/public/sitl'
+    ],
   },
   rebuildConfig: {},
   plugins: [
@@ -43,6 +46,59 @@ export default {
     },
   ],
   hooks: {
+    // Remove SITL binaries for other platforms/architectures to reduce package size
+    postPackage: async (forgeConfig, options) => {
+      for (const outputPath of options.outputPaths) {
+        let sitlPath;
+
+        if (options.platform === 'darwin') {
+          // macOS app bundle structure: <outputDir>/<AppName>.app/Contents/Resources/sitl
+          // Find the .app directory
+          const appBundles = fs.readdirSync(outputPath).filter(f => f.endsWith('.app'));
+          if (appBundles.length === 0) {
+            console.log(`postPackage: No .app bundle found in ${outputPath}`);
+            continue;
+          }
+          sitlPath = path.join(outputPath, appBundles[0], 'Contents', 'Resources', 'sitl');
+        } else {
+          // Windows/Linux: <outputPath>/resources/sitl
+          sitlPath = path.join(outputPath, 'resources', 'sitl');
+        }
+
+        console.log(`postPackage: Checking SITL path for ${options.platform}: ${sitlPath}`);
+        if (!fs.existsSync(sitlPath)) {
+          console.log(`postPackage: SITL path not found, skipping: ${sitlPath}`);
+          continue;
+        }
+
+        if (options.platform === 'win32') {
+          console.log('postPackage: Removing non-Windows SITL binaries (linux, macos)');
+          fs.rmSync(path.join(sitlPath, 'linux'), { recursive: true, force: true });
+          fs.rmSync(path.join(sitlPath, 'macos'), { recursive: true, force: true });
+        } else if (options.platform === 'darwin') {
+          console.log('postPackage: Removing non-macOS SITL binaries (linux, windows)');
+          fs.rmSync(path.join(sitlPath, 'linux'), { recursive: true, force: true });
+          fs.rmSync(path.join(sitlPath, 'windows'), { recursive: true, force: true });
+        } else if (options.platform === 'linux') {
+          console.log('postPackage: Removing non-Linux SITL binaries (macos, windows)');
+          fs.rmSync(path.join(sitlPath, 'macos'), { recursive: true, force: true });
+          fs.rmSync(path.join(sitlPath, 'windows'), { recursive: true, force: true });
+          // Remove wrong architecture
+          if (options.arch === 'x64') {
+            fs.rmSync(path.join(sitlPath, 'linux', 'arm64'), { recursive: true, force: true });
+          } else if (options.arch === 'arm64') {
+            // Move arm64 binary to linux root and remove x64
+            const arm64Binary = path.join(sitlPath, 'linux', 'arm64', 'inav_SITL');
+            const destBinary = path.join(sitlPath, 'linux', 'inav_SITL');
+            if (fs.existsSync(arm64Binary)) {
+              fs.rmSync(destBinary, { force: true });
+              fs.renameSync(arm64Binary, destBinary);
+              fs.rmSync(path.join(sitlPath, 'linux', 'arm64'), { recursive: true, force: true });
+            }
+          }
+        }
+      }
+    },
     // Uniform artifact file names
     postMake: async (config, makeResults) => {
       makeResults.forEach(result => {

js/configurator_main.js

@@ -138,6 +138,21 @@ $(function() {
                     return;
                 }
 
+                // Check for unsaved changes in current tab before switching
+                if (GUI.active_tab === 'javascript_programming' &&
+                    TABS.javascript_programming &&
+                    TABS.javascript_programming.isDirty) {
+                    console.log('[Tab Switch] Checking for unsaved changes in JavaScript Programming tab');
+                    const confirmMsg = i18n.getMessage('unsavedChanges') ||
+                        'You have unsaved changes. Leave anyway?';
+
+                    if (!confirm(confirmMsg)) {
+                        console.log('[Tab Switch] User cancelled tab switch');
+                        return; // Cancel tab switch
+                    }
+                    console.log('[Tab Switch] User confirmed tab switch');
+                }
+
                 GUI.tab_switch_in_progress = true;
 
                 GUI.tab_switch_cleanup(function () {
@@ -285,6 +300,15 @@ $(function() {
                         var check = $(this).is(':checked');
                         store.set('update_notify', check);
                     });
+
+                    if (store.get('disable_3d_acceleration', false)) {
+                        $('div.disable_3d_acceleration input').prop('checked', true);
+                    }
+
+                     $('div.disable_3d_acceleration input').on('change', function () {
+                        var check = $(this).is(':checked');
+                        store.set('disable_3d_acceleration', check);
+                    });
 
                     $('div.statistics input').on('change', function () {
                         var check = $(this).is(':checked');

js/connection/connectionBle.js

@@ -48,7 +48,6 @@ class ConnectionBle extends Connection {
         this._writeCharacteristic   = false;
         this._device                = false;
         this._deviceDescription     = false;
-        this._onCharateristicValueChangedListeners = [];
         this._onDisconnectListeners   = [];
         this._reconnects = 0;
         this._handleOnCharateristicValueChanged = false;
@@ -166,11 +165,13 @@ class ConnectionBle extends Connection {
                         buffer[i] = event.target.value.getUint8(i);
                     }
 
-                    this._onCharateristicValueChangedListeners.forEach(listener => {
-                        listener({
-                            connectionId: 0xFF,
-                            data: buffer
-                        });
+                    const info = {
+                        connectionId: 0xFF,
+                        data: buffer
+                    };
+
+                    this._onReceiveListeners.forEach(listener => {
+                        listener(info);
                     });
                 };
 
@@ -242,11 +243,11 @@ class ConnectionBle extends Connection {
     }
 
     addOnReceiveCallback(callback){
-        this._onCharateristicValueChangedListeners.push(callback);
+        this._onReceiveListeners.push(callback);
     }
 
     removeOnReceiveCallback(callback){
-        this._onCharateristicValueChangedListeners = this._onCharateristicValueChangedListeners.filter(listener => listener !== callback);
+        this._onReceiveListeners = this._onReceiveListeners.filter(listener => listener !== callback);
     }
 
     addOnReceiveErrorCallback(callback) {