Maintenance 9.x merge to master

[sensei-hacker]

PR Type

Other

---

Description

This description is generated by an AI tool. It may have inaccuracies

• Removes js/transpiler/api/definitions/gvar.js file

• Maintenance release merging 9.x branch to master

---

Diagram Walkthrough

flowchart LR
  A["maintenance-9.x branch"] -- "merge" --> B["master branch"]
  C["gvar.js"] -- "removed" --> B

Loading

File Walkthrough

	Relevant files

---

[github-actions]

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

• maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

• maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.

---

This is an automated suggestion to help route contributions to the appropriate branch.

[qodo-code-review]

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

[qodo-code-review]

Suggestion: Correct the test runner logic to accurately count failed tests by checking the return value of runTest and incrementing the failed counter, ensuring the script reports failures correctly. [possible issue, importance: 7]

Suggested change

	let passed = 0;
	let failed = 0;
	// Test 1: Basic throttle override still works
	passed += runTest('throttle override compiles', () => {
	const code = `
	const { flight, override } = inav;
	if (flight.isArmed) {
	override.throttle = 1500;
	}`;
	const transpiler = new Transpiler();
	const result = transpiler.transpile(code);
	if (!result.success) {
	throw new Error(`Compilation failed: ${result.error}`);
	}
	assertEquals(result.success, true, 'Compilation should succeed');
	assertContains(result.commands.join(' '), '29', 'Should contain operation 29 (OVERRIDE_THROTTLE)');
	});
	let passed = 0;
	let failed = 0;
	// Test 1: Basic throttle override still works
	if (runTest('throttle override compiles', () => {
	const code = `
	const { flight, override } = inav;
	if (flight.isArmed) {
	override.throttle = 1500;
	}`;
	const transpiler = new Transpiler();
	const result = transpiler.transpile(code);
	if (!result.success) {
	throw new Error(`Compilation failed: ${result.error}`);
	}
	assertEquals(result.success, true, 'Compilation should succeed');
	assertContains(result.commands.join(' '), '29', 'Should contain operation 29 (OVERRIDE_THROTTLE)');
	})) {
	passed++;
	} else {
	failed++;
	}

[qodo-code-review]

Suggestion: Avoid prematurely resetting the isDirty flag when a user confirms disconnecting with unsaved changes. The flag should only be reset upon saving or explicitly discarding the changes to prevent potential data loss. [possible issue, importance: 8]

Suggested change

	// Clear isDirty flag so tab switch during disconnect doesn't show warning again
	TABS.javascript_programming.isDirty = false;
	// The isDirty flag should be reset when changes are saved or explicitly discarded,
	// not just by confirming a disconnect.
	// TABS.javascript_programming.isDirty = false;

[qodo-code-review]

Suggestion: After guarding for null, explicitly invoke the continuation with an error-safe path so the async flow doesn't hang; also correct the log typo. [Learned best practice, importance: 6]

Suggested change

	mspHelper.getSetting("align_mag_roll").then(function (data) {
	if (data == null) {
	console.log("while settting align_mag_roll, data is null or undefined");
	return;
	}
	self.alignmentConfig.roll = parseInt(data.value, 10) / 10;
	}).then(callback)
	mspHelper.getSetting("align_mag_roll").then(function (data) {
	if (data == null) {
	console.warn("while setting align_mag_roll, data is null or undefined");
	return Promise.resolve();
	}
	self.alignmentConfig.roll = parseInt(data.value, 10) / 10;
	}).then(callback).catch(err => {
	console.error('Failed to get align_mag_roll:', err);
	callback();
	});