Skip to content

Prevent double-free in attemptDirectScanout #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Prevent double-free in attemptDirectScanout #10974

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1bf7a0
fix buffer double free
Kam1k4dze Jul 9, 2025
e109574
improve
Kam1k4dze Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/helpers/Monitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,10 @@ bool CMonitor::attemptDirectScanout() {
// lock buffer while DRM/KMS is using it, then release it when page flip happens since DRM/KMS should be done by then
// btw buffer's syncReleaser will take care of signaling release point, so we don't do that here
PBUFFER->lock();
PBUFFER->onBackendRelease([PBUFFER]() { PBUFFER->unlock(); });
PBUFFER->onBackendRelease([wb = WP<IHLBuffer>{PBUFFER}] {
if (wb)
wb->unlock();
});

return true;
}
Expand Down
Loading