handle setGroupCurrent properly on fulscreen groups #10920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/desktop/Window.cpp
vaxerski
reviewed
Jul 4, 2025
vaxerski
approved these changes
Jul 4, 2025
FrancisTheCat
pushed a commit
to FrancisTheCat/Hyprland
that referenced
this pull request
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always warps window size and pos on
setGroupCurrentreplaces hacky solution for restoring last floating size and pos by just overriding the values set when changing in/out of fullscreen
seems to work fine
example of what this fixes:
create a workspace with a window and a group with 2 windows
fulscreen the group
change the active group window
notice it always animates