Skip to content

Rename MultiUseSandbox -> Sandbox, UninitializedSandbox::evolve -> UninitializedSandbox::init #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Rename MultiUseSandbox -> Sandbox, UninitializedSandbox::evolve -> UninitializedSandbox::init #762

wants to merge 5 commits into from
+149 −150

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented Aug 4, 2025

Rename MultiUseSandbox as Sandbox.
Rename UninitializedSandbox::evolve as UninitializedSandbox::init

@jprendes jprendes added the kind/refactor For PRs that restructure or remove code without adding new functionality. label Aug 4, 2025
ludfjig
ludfjig previously approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I am thinking we might want to take this chance to do other breaking changes such as determining which module Sandbox belongs to, and whether or not we want to any re-exports of Sandbox at all.

src/hyperlight_host/src/lib.rs
@@ -74,7 +74,7 @@ pub use error::HyperlightError;
/// Re-export for `MemMgrWrapper` type
/// A sandbox that can call be used to make multiple calls to guest functions,
/// and otherwise reused multiple times
pub use sandbox::MultiUseSandbox;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can take this chance to remove these reexports? I'm not sure there is a reason to keep these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #765 to see what we want to expose as our public API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludfjig ludfjig ludfjig approved these changes

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees
No one assigned
Labels
kind/refactor For PRs that restructure or remove code without adding new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprendes @ludfjig