Bring back the previous behavior of call_guest_function_by_name
#761
+194
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset and
simongdavies
as code owners
jprendes
force-pushed
the
snapshot2
branch
2 times, most recently
from
ee49c52 to
d99d24b
Compare
jsturtevant
previously approved these changes
Aug 4, 2025
jprendes
force-pushed
the
snapshot2
branch
2 times, most recently
from
fc3eb8c to
4026423
Compare
dblnz
previously approved these changes
Aug 5, 2025
ludfjig
previously approved these changes
Aug 5, 2025
It looks like we need to provide a way for this to choose the behavior, or we need to break it/keep current behavior |
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back the previous behaviour of
call_guest_function_by_name, and exposes the new behavioud behind a different name:run.Originally I wanted to call the new behaviour
call, but that method exists as an alias tocall_guest_function_by_namethroughtCallabletrait.The risk of using the
callname is that anyone using theCallabletrait would get an (almost) silent change in behaviour (almost because there would be a lint aboutCallablebeing unused).Let me know if anyone prefers a different name.