Use eth69 in unit tests #8859
Merged
Use eth69 in unit tests #8859
+190
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…g due to old code Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…69-for-unit-tests
Signed-off-by: Matilda Clerke <[email protected]>
…se-eth69-for-unit-tests
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…sSufficientValidators due to flakyness Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda-Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
macfarla
approved these changes
Jun 30, 2025
macfarla
reviewed
Jun 30, 2025
.../src/test/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncStepTest.java
Outdated
Show resolved
Hide resolved
|
Discussed with Stefan and we decided it'd be best not to remove the total difficulty as I've done in this PR. I'll start work on reverting it now. |
This reverts commit ff4526d. Signed-off-by: Matilda Clerke <[email protected]>
This reverts commit 493b84f. Signed-off-by: Matilda Clerke <[email protected]>
This reverts commit ea0a26c. Signed-off-by: Matilda Clerke <[email protected]>
This reverts commit 40f8af6. Signed-off-by: Matilda Clerke <[email protected]>
…luator" This reverts commit 23ffb26. Signed-off-by: Matilda Clerke <[email protected]>
…e looping due to old code" This reverts commit c430125. Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…rTest Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…gerTest Signed-off-by: Matilda Clerke <[email protected]>
…oaderForkTest Signed-off-by: Matilda Clerke <[email protected]>
Matilda-Clerke
force-pushed
the
use-eth69-for-unit-tests
branch
from
9cb4860 to
ebec9ae
Compare
…Test Signed-off-by: Matilda Clerke <[email protected]>
macfarla
reviewed
Jul 11, 2025
| @@ -122,6 +122,7 @@ public static RespondingEthPeer createPeer( | |||
| return RespondingEthPeer.builder() | |||
| .ethProtocolManager(ethProtocolManager) | |||
| .totalDifficulty(td) | |||
| .capability(EthProtocol.ETH68) | |||
There was a problem hiding this comment.
why do these createPeer methods use ETH68?
There was a problem hiding this comment.
Eth69 removes total difficulty from the status message, but many of our tests rely on total difficulty in one way or another so for those tests I created peers using Eth68.
macfarla
reviewed
Jul 11, 2025
...eum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/messages/Eth69StatusMessageTest.java
Outdated
Show resolved
Hide resolved
…essages/Eth69StatusMessageTest.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Use eth/69 in unit tests
Fixed Issue(s)
#8728