Skip to content

feat(types): add JSDoc annotations #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Qsppl
Copy link
Contributor

@Qsppl Qsppl commented Mar 17, 2025

No description provided.

@Qsppl Qsppl mentioned this pull request Mar 17, 2025
@coveralls
Copy link

Coverage Status

coverage: 99.914%. remained the same
when pulling c9f280e on Qsppl:add-JSDoc-annotations
into 266e364 on hybridsjs:main.

@smalluban
Copy link
Contributor

Very cool! I like it.

@Qsppl
Copy link
Contributor Author

Qsppl commented Mar 18, 2025

Thank you. I continue in same style.

@Qsppl
Copy link
Contributor Author

Qsppl commented Mar 18, 2025

I am currently searching for all public API subjects.

I found that some functions and complex overloads are not documented.

There are also some minor overloads that are not decorated as overloads and some inconsistency in the documentation headers.

Should I create Issues or will we do all the side work within this request?

@smalluban
Copy link
Contributor

smalluban commented Mar 20, 2025

We can pack all of the docs updates in one PR and add JSDocs in a separate one. If you think there are inconsistencies, you can create a PR or issue for that first (on sie side). This should be merged before adding JSDocs on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants