Skip docs-missing checks for release PRs #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
approved these changes
Jun 27, 2025
ludeeus
reviewed
Jun 30, 2025
| @@ -25,6 +25,8 @@ export class DocsMissing extends BaseWebhookHandler { | |||
| PullRequestLabeledEvent | PullRequestUnlabeledEvent | PullRequestSynchronizeEvent | |||
| >, | |||
| ) { | |||
| const isReleasePR = context.payload.pull_request.base.ref === 'master'; | |||
There was a problem hiding this comment.
In an ideal world this is true, but it is possible to open a PR against master without it being a release.
I think this should have been isPRAgainstMaster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release PRs are different; we merge the branches and don't have a direct documentation PR for them.
This PR adjust the behavior to prevent a constant check error on those PRs. Added tests.