Update instructions to build and run the rpc relay #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bguiz
reviewed
Jun 24, 2023
tutorials/more-tutorials/json-rpc-connections/hedera-json-rpc-relay.md
Outdated
Show resolved
Hide resolved
|
@bguiz I have committed your suggestions :) |
theekrystallee
requested changes
Jun 24, 2023
There was a problem hiding this comment.
Hi @satwikkansal, thanks for the PR! One last thing before we merge, could you please include a Signed-off-by line in the commit message? Here are steps to resolve the failed check.
Once the DCO check passes, will approve and merge. Thanks again!
Add missing steps Signed-off-by: root <[email protected]>
…relay.md Co-authored-by: Brendan Graetz <[email protected]> Signed-off-by: root <[email protected]>
|
@theekrystallee done now! |
theekrystallee
approved these changes
Jun 26, 2023
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs were missing couple of steps to build and run the relay server