Fix Windows build with clang: replace swprintf_s with portable alternative #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally use swprintf() for clang to avoid undefined symbol __local_stdio_printf_options while keeping swprintf_s() for MSVC. Resolves Windows build failure with LLVM/clang linker.
|
Seems right to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use conditional compilation to call swprintf() when building with clang instead of swprintf_s(), which depends on the Microsoft-specific __local_stdio_printf_options symbol that's not available with LLVM's linker.
This resolves the linker error:
ld.lld: error: undefined symbol: __local_stdio_printf_options
The change maintains compatibility with both MSVC (using swprintf_s) and clang (using standard swprintf) while preserving the same functionality.
resolves #101