Skip to content

Avoid panic during startup with 1.10.2 #26219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

Conversation

Juanadelacuesta
Copy link
Member

@Juanadelacuesta Juanadelacuesta commented Jul 8, 2025

Description

This PR addresses GH-23203. When starting the nomad client on linux with no fingerprinting, it panics because no topology is assigned. This PR initialises the topology as an empty one to avoid nil
pointers.

Testing & Reproduction steps

To reproduces it, just start a client on linux with:

  options = {
    "fingerprint.allowlist" = "network"
  }
}

And see it panic.

Links

GH-23203.

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@Juanadelacuesta Juanadelacuesta linked an issue Jul 8, 2025 that may be closed by this pull request
@Juanadelacuesta Juanadelacuesta changed the title func: initialize topology to avoid nil pointers Avoid panic during startup with 1.10.2 Jul 8, 2025
@Juanadelacuesta Juanadelacuesta added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.10.x backport to 1.10.x release line labels Jul 8, 2025
@Juanadelacuesta Juanadelacuesta marked this pull request as ready for review July 8, 2025 12:39
@Juanadelacuesta Juanadelacuesta requested review from a team as code owners July 8, 2025 12:39
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Juanadelacuesta Juanadelacuesta merged commit 3b44090 into main Jul 8, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.10.x backport to 1.10.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic during startup with 1.10.2
2 participants