-
Notifications
You must be signed in to change notification settings - Fork 2k
Add node_pool to blockedEval metric #26215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
356fdae
to
6bbff40
Compare
6bbff40
to
eb68f3f
Compare
eb68f3f
to
9343575
Compare
nomad/blocked_evals_stats.go
Outdated
@@ -92,6 +94,9 @@ func generateResourceStats(eval *structs.Evaluation) *BlockedResourcesStats { | |||
for class := range allocMetrics.ClassExhausted { | |||
classes[class] = struct{}{} | |||
} | |||
|
|||
nodepools[allocMetrics.NodePool] = struct{}{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a probably minor thing, but all the FailedTGAllocs
for a given evaluation will belong to the same node pool, because an evaluation is for a specific job and a job can only exist in a single node pool.
Rather than repeating the node pool name on the AllocMetrics
structs, maybe we should just stick the node pool field on the Evaluation
itself? If we wrote the field whenever we created the eval, we could potentially use that in the future for some of the zany ideas we've knocked around like per-pool scheduler workers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, yeah that sounds good to me! I wasn't sure that Evaluation
would be the right place to add a field that was only going to be used in a metric label, but if there are possible future applications I'd be happy put it there.
@allisonlarson The website/content/docs/operations/metrics-reference.mdx is now website/content/docs/reference/metrics.mdx |
Adds the node_pool to the blockedEval metrics that get emitted for resource/cpu, along with the dc and node class.
9343575
to
858eecf
Compare
858eecf
to
5adb4f8
Compare
dc25db2
to
83ee53e
Compare
Description
Adds the node_pool to the blockedEval metrics that get emitted for
resource/cpu, along with the dc and node class.
Testing & Reproduction steps
The node_pool has been added to the automated tests, and seen when using manual tests and observing metrics emitted.
Links
Fixes #25933
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.