scheduler: basic cluster reconciler safety properties for service jobs #26167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
changed the title
tgross
added a commit
that referenced
this pull request
Jun 30, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jun 30, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 1, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 1, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 1, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 1, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 1, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 1, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 1, 2025
To help break down the larger property tests we're doing in #26167 and #26172 into more manageable chunks, pull out a property test for just the `reconcileReconnecting` method. This method helpfully already defines its important properties, so we can implement those as test assertions. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167 Ref: #26172
tgross
added a commit
that referenced
this pull request
Jul 2, 2025
To help break down the larger property tests we're doing in #26167 and #26172 into more manageable chunks, pull out a property test for just the `reconcileReconnecting` method. This method helpfully already defines its important properties, so we can implement those as test assertions. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167 Ref: #26172
pkazmierczak
force-pushed
the
f-prop-testing-reconciler-safety
branch
from
718a1fb to
da09f1a
Compare
tgross
added a commit
that referenced
this pull request
Jul 7, 2025
To help break down the larger property tests we're doing in #26167 and #26172 into more manageable chunks, pull out a property test for just the `reconcileReconnecting` method. This method helpfully already defines its important properties, so we can implement those as test assertions. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167 Ref: #26172
tgross
added a commit
that referenced
this pull request
Jul 7, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 7, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 8, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 8, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 8, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 8, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 8, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 8, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
previously approved these changes
Jul 9, 2025
| for _, tg := range ar.jobState.Job.TaskGroups { | ||
| count += tg.Count | ||
| } | ||
| if len(results.Place) > count { |
There was a problem hiding this comment.
In my PR I've got the same property but it doesn't really matter whether there's a deployment or existing allocs or not.
tgross
approved these changes
Jul 9, 2025
tgross
added a commit
that referenced
this pull request
Jul 9, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 9, 2025
Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 9, 2025
Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 9, 2025
…26172) Property test assertions for the core safety proprerties of the cluster reconciler, for batch jobs. The changeset includes fixes for any bugs found during work-in-progress, which will get pulled out to their own PRs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
tgross
added a commit
that referenced
this pull request
Jul 9, 2025
…26216) Property test assertions for the core safety properties of the node reconciler, for system jobs. Ref: https://hashicorp.atlassian.net/browse/NMD-814 Ref: #26167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ref: https://hashicorp.atlassian.net/browse/NMD-814