Support Tor #758
Support Tor #758
Conversation
…support using `cretz/bine`.
This means Dalfox can now run its own Tor SOCKS proxy, so you won't always need an external Tor service if you want Tor connectivity.
Here are the main changes:
- I've included `github.com/cretz/bine` to handle the embedded Tor process.
- There's a new `--enable-embedded-tor` flag. If you use this, Dalfox will try to start its own Tor SOCKS proxy.
- By default, this embedded Tor proxy will use SOCKS port 9055 to avoid issues with standard Tor setups that often use port 9050.
- If the embedded Tor starts up correctly, Dalfox will send its traffic through this internal proxy.
- The `--tor` flag you might already be familiar with now mainly indicates you want to use Tor.
- If you also use `--enable-embedded-tor`, the embedded Tor will be the first choice.
- If embedded Tor doesn't start, or if you don't use `--enable-embedded-tor` but do use `--tor`, Dalfox will try to use an external Tor proxy at `socks5://127.0.0.1:9050`.
- I've set up how the embedded Tor process starts, stops, and cleans up its temporary data directory.
- I've also added some logging so you can clearly see what's happening with Tor initialization (whether it's embedded or external) and any errors that might pop up.
This should make it simpler for you to use Tor's privacy features without needing to set up and manage a separate Tor service yourself.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hahwul, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request adds significant networking flexibility by integrating Tor support. Users can now route their scanning traffic through the Tor network, either by leveraging an existing external Tor proxy or by opting to start an experimental embedded Tor instance managed by the application. This enhances privacy and potentially helps bypass certain network restrictions during scans.
Highlights
- Tor Support: Introduced support for routing traffic through the Tor network.
- Embedded Tor: Added an experimental feature to start and manage an embedded Tor SOCKS proxy directly within the application using the
binelibrary. - External Tor Fallback: Implemented logic to fall back to using a standard external Tor SOCKS proxy (defaulting to 127.0.0.1:9050) if the embedded Tor option is not enabled or fails to start, provided the
--torflag is used. - New Flags: Added
--torand--enable-embedded-torcommand-line flags to control Tor usage.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
No description provided.