Skip to content

Feat: CLI support + Enhancements #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

jeafreezy
Copy link
Contributor

What does this PR do?

This PR will be closing #23 .

It includes the following:

  • Improved typing in the codebase and the CLI command.
  • ReadMe example update.
  • Unit tests for the CLI functionalities.
  • improved logging in the codebase (also turned on osmnx logging for improved UX).
  • Renamed 'source' with 'fetcher' in the CLI option.
  • Used an enum for the source.
  • Some argument validations.

Screenshots

Screen.Recording.2025-07-07.at.00.05.35.mov

Everything works fine over here. Kindly review @denironyx .

All the commands run successfully. But I coudln't see anything in the terminal. What do you envisage the user see after running the commands in the cli ?

@jeafreezy
Copy link
Contributor Author

This is long overdue @denironyx . Apologies for the delay, I just got my schedule in order.

@denironyx denironyx merged commit 2b4d42d into graphgeeks-lab:main Jul 25, 2025
@denironyx
Copy link
Contributor

Thanks @jeafreezy ! And regarding your observation.. The reason you are not seeing any exported file, is because, at the moment graphfaker isn't exporting data.. which is something, I will be working on over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants