Skip to content

fix(codeowners): update ownership of generate-openapi-clients action #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dblinkhorn
Copy link
Contributor

@dblinkhorn dblinkhorn commented Aug 4, 2025

CODEOWNERS currently attributes ownership to Platform CAT. The new owners should be @grafana/grafana-app-platform-squad .

  • Added @grafana/grafana-app-platform-squad to teams for this repo
  • Updated ownership of actions/generate-openapi-clients action

@dblinkhorn dblinkhorn requested a review from a team as a code owner August 4, 2025 19:20
@cindy
Copy link

cindy commented Aug 4, 2025

This was owned by monitoring but it is going to be owned by app platform.

@dblinkhorn
Copy link
Contributor Author

dblinkhorn commented Aug 4, 2025

This was owned by monitoring but it is going to be owned by app platform.

Good to know, thanks! I'll make another commit to fix it.

Do you happen to know the correct team here?

image

@cindy
Copy link

cindy commented Aug 4, 2025

This was owned by monitoring but it is going to be owned by app platform.

Good to know, thanks! I'll make another commit to fix it.

Do you happen to know the correct team here?

image

I believe it's grafana app platform.

@ArturWierzbicki
Copy link

hey @radiohead / @spinillos - sorry i dont what this is - is it related to cog/foundation-sdk?

@dblinkhorn dblinkhorn force-pushed the dblinkhorn/update-ownership-generate-openapi-clients branch from 6021d8b to 0f919d7 Compare August 4, 2025 21:23
@dblinkhorn dblinkhorn force-pushed the dblinkhorn/update-ownership-generate-openapi-clients branch from 0f919d7 to 47df9ea Compare August 4, 2025 21:24
@ArturWierzbicki
Copy link

hey @dblinkhorn / @cindy , i looked at the implementation of this action and it looks like a one-off for golang - i dont think we should own this, we agreed on owning just https://github.com/grafana/cog and https://github.com/grafana/grafana-foundation-sdk

@guicaulada guicaulada requested review from a team and charandas and removed request for a team August 5, 2025 19:16
@guicaulada
Copy link
Contributor

guicaulada commented Aug 5, 2025

I feel like the ones that should approve this change are the ones being assigned as owners, for that I have removed the platform-productivity team review request.

Discussion seems to be still open, so in case ownership changes from app platform to a different team, please request a review from the new owners.

@radiohead radiohead requested review from ArturWierzbicki and removed request for charandas August 6, 2025 08:44
Copy link

@ArturWierzbicki ArturWierzbicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spinillos
Copy link
Member

This shared-workflow action isn't related to cog or foundation-sdk.

@cindy
Copy link

cindy commented Aug 6, 2025

@spinillos who owns this? Is it monitoring? 🤔 Who previously maintained it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants