LazyLoading: Unmount panels out of view #1147
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick test to improve lazy loading in scenes.
Lazy loading in the old architecture is actually much better as it lazy loads the panels on first load and does not cause queries to be issued for panels out of view while in scenes we only do lazy loading for initial load.
A quick solution would be to unmount when things go out of view, but a big drawback to this simple approach is that now queries will be cancelled when you scroll a loading panel out of view so in order to see the results of a panel that takes a long time to load you have to keep it in view.
Think we also need to to do a quick poc on passing isInView as a prop to viz panel rendering and scene query runner