fix: construct delayed downscale pod FQDN using both service and sts name #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyasp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
The DNS entry for a pod of a StatefulSet is (docs):
createPrepareDownscaleEndpointsassumed a StatefulSet's.metadata.namewas equal to its.spec.serviceName. That works in Mimir's Jsonnet deployment, but does not for Mimir's Helm chart. This is similar to the fix in #221.I pulled the FQDN construction into a common method to hopefully reduce the chance of this drifting again in the future. A consequence of doing that was the prepare downscale path now specifies a trailing
.as well when it did not before. That is not a required change for this particular fix, but it seemed right to do anyway (reduces DNS lookups).