Support for per-zone PDB #253
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes; * new web-hook handler for pod eviction added to rollout-operator * manifests for new custom resource definition for configuring the PDBZ * updated development example files and environment
|
|
charleskorn
reviewed
Aug 1, 2025
development/custom-resource-definition-pod-disruption-zone-budget.yaml
Outdated
Show resolved
Hide resolved
development/custom-resource-definition-pod-disruption-zone-budget.yaml
Outdated
Show resolved
Hide resolved
* rename to ZoneAwarePodDisruptionBudget * updated root README * updates to main eviction handler per PR *
* updates per PR review * added ZPDB informer to monitor ZPDB configurations * added Pod informer to work with pod eviction cache * added pod eviction cache * added validating webhook configuration for ZPDB files * added locking for concurrent eviction handling
4 tasks
charleskorn
reviewed
Aug 6, 2025
.golangci.yaml
Outdated
There was a problem hiding this comment.
This change seems unrelated - am I missing something?
|
|
||
| This allows an operator to perform maintenance on a single zone whilst ensuring sufficient pod availability in other zones. | ||
|
|
||
| Consider the following topology where the `PDZB` has `maxUnavailability=1`; |
There was a problem hiding this comment.
Suggested change
| Consider the following topology where the `PDZB` has `maxUnavailability=1`; | |
| Consider the following topology where the `ZPDB` has `maxUnavailable` set to 1: |
Comment on lines
+437
to
+441
| If `ingester-zone-a-0` is to be evicted, it will be allowed if there are no disruptions in either zone `b` or zone `c`. | ||
|
|
||
| If `ingester-zone-a-1` has failed and `ingester-zone-a-0` is to be evicted, it will be allowed if there are no disruptions in either zone `b` or zone `c`. | ||
|
|
||
| *The already disrupted zone can be further disrupted as long as the other zones meet the unavailability criteria.* |
There was a problem hiding this comment.
Sorry, I should have caught this earlier, this isn't quite right - we still want to limit the number of pods allowed to become unavailable :
Suggested change
| If `ingester-zone-a-0` is to be evicted, it will be allowed if there are no disruptions in either zone `b` or zone `c`. | |
| If `ingester-zone-a-1` has failed and `ingester-zone-a-0` is to be evicted, it will be allowed if there are no disruptions in either zone `b` or zone `c`. | |
| *The already disrupted zone can be further disrupted as long as the other zones meet the unavailability criteria.* | |
| If `ingester-zone-a-0` is to be evicted, it will be allowed if there are no disruptions in either zone `a`, zone `b` or zone `c`. | |
| If `ingester-zone-a-1` has failed and `ingester-zone-a-0` is to be evicted, it will not be allowed. |
It might be good to add another example where maxUnavailability is set higher than 1 to illustrate what happens in that case as well.
charleskorn
reviewed
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for the implementation of a custom pod disruption budget which is zone aware.
#194
Included in this PR;
Note - this is a draft PR to give early visibility to @charleskorn and to share details on the new custom resource definition.
Relates to grafana/mimir#12315