feat: Add ingester_chunks_flush_requests_total #18696
Open
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to create an alert for when object store flushes are not successful Currently there is no metric counting all flushes (successful and unsuccessful). There's ingester_chunks_flushed_total but that one just counts successful flushes (split by reason). For the alert it would be beneficial to have the ratio of failures compared to the total amount of "flush requests", so that the threshold for the alert is not based on an absolute rate.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to create an alert for when object store flushes are not successful Currently there is no metric counting all flushes (successful and unsuccessful). There's ingester_chunks_flushed_total but that one just counts successful flushes (split by reason). For the alert it would be beneficial to have the ratio of failures compared to the total amount of "flush requests", so that the threshold for the alert is not based on an absolute rate.
Which issue(s) this PR fixes:
Related with https://issues.redhat.com/browse/LOG-6238
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR