Browser: remove undefined headers from route.continue/fulfill #5004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
AgnesToulet
force-pushed
the
browser/route-improve-headers-parsing
branch
from
8c6e77e to
4a8ae6c
Compare
AgnesToulet
requested review from
ankur22 and
codebien
and removed request for
a team
AgnesToulet
changed the title
mstoykov
requested changes
Aug 1, 2025
| result := make([]common.HTTPHeader, 0, len(headersKeys)) | ||
| for _, hk := range headersKeys { | ||
| // Skip undefined headers | ||
| if headers.Get(hk).String() == "undefined" { |
There was a problem hiding this comment.
Can we:
- get the value once and use it to check and to go to string below
- here check that the value is undefined, not that it gets stringified to "undefined"
ankur22
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates how we parse headers for the
route.continueandroute.fulfillfunctions to remove the headers withundefinedvalues.Why?
Else these headers are sent with
"undefined"as a string instead of a null value.Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)