database_observability: pg query redaction #4170
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds SQL query redaction capabilities to the PostgreSQL database observability component, including: - SQL lexer for extracting table names from queries - Query redaction logic - Comprehensive test coverage This builds upon the samples collection functionality to add security-focused query analysis.
gaantunes
requested review from
cristiangreco,
matthewnolf,
fridgepoet,
clayton-cornell and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is adding query redaction capabilities to the
activitycollector.Additionally, this places all normalizer functions into a pg_lexer.go file, for better structure,
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist