Upgrade Beyla component to 2.5.4 #4100
Conversation
|
|
|
💻 Deploy preview available: |
| @@ -55,6 +55,8 @@ Main (unreleased) | |||
|
|
|||
| - Add `application_host` and `network_inter_zone` features to `beyla.ebpf` component. (@marctc) | |||
|
|
|||
| - Upgrade `beyla.ebpf` to version Beyla v2.5.4 The full list of changes can be found in the [Beyla release notes](https://github.com/grafana/beyla/releases/tag/v2.5.4) (@marctc) | |||
There was a problem hiding this comment.
It'd be good to mention which version we're upgrading from. After all users would need to check the changelogs of all the intermediate versions too.
There was a problem hiding this comment.
It'd be especially good to mention any breaking changes. Normally breaking changes should be described in the release notes in more detail.
There was a problem hiding this comment.
Do we also want to put there breaking changes from things that are not config? We introduced some breaking changes that are more from behaviour but I dont think honestly affects much to the component.
| The `traces` block contains the following sub-blocks: | ||
|
|
||
| - [`sampler`][sampler] - configures global trace sampling settings. See the [`sampler`][sampler] section for detailed configuration options. |
There was a problem hiding this comment.
For child blocks, this is usually documented in the blocks table (lines 67-89). I'd expect that a child block of traces be added between lines 88 and 89
I've added this as a comment to that section of the table. If this is correct, then lines 334-336 should be deleted.
There was a problem hiding this comment.
Hey @clayton-cornell, the thing is the sampler section has the same config block for the block traces and for each invidual discovery service section, so I wanted to avoid repeat the block
There was a problem hiding this comment.
We shouldn't have to repeat the block. It's defined once (below on lines 369-390). If it's noted as a child block in the block table, then it's all consistent with other component topics that have child blocks in multiple places. We don't note child block hierarchy in the block descriptions... only in the block tables.
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
|
We are working on 2.5.5 maybe we can pick that up as well, it has a fix that you can only enable span metrics without application metrics. |
PR Description
This PR upgrades Beyla component to release 2.5 (v2.5.4).
Which issue(s) this PR fixes
Closes #3780
PR Checklist