Fix metadata propagation from scrape to otel components #4098
+781
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes propagation of metric metadata, but only for pipelines which start with a prometheus.scrape and transition into otelcol components. The metrics need to be sent by an otelcol exporter.
I can see the metadata in live debugging. Before:
After:
Which issue(s) this PR fixes
Related to #547
Notes to the Reviewer
I need to assess the performance impact of this feature before writing the docs and before opening the PR for review.
For now it'd be good to keep it as an experimental opt-in feature until we're sure it's stable and without consuming much more resources.
PR Checklist