Skip to content

recovery: Default to 60 minutes #16005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dominic-r
Copy link
Contributor

Adds a "this recovery code is valid for X", adds testing, and changes default to 60 min

For 2025.10 most certainly

Signed-off-by: Dominic R [email protected]
Closes: #15999

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@dominic-r dominic-r requested a review from a team as a code owner August 6, 2025 15:43
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit c9b06c3
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6893780ea8e14d0007d08552
😎 Deploy Preview https://deploy-preview-16005--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit c9b06c3
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6893780e38d1c90008e8016e
😎 Deploy Preview https://deploy-preview-16005--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit c9b06c3
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6893780efb435d0007c2bf5a
😎 Deploy Preview https://deploy-preview-16005--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.57%. Comparing base (90274b3) to head (c9b06c3).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16005      +/-   ##
==========================================
- Coverage   92.71%   92.57%   -0.15%     
==========================================
  Files         833      833              
  Lines       44731    44947     +216     
==========================================
+ Hits        41472    41608     +136     
- Misses       3259     3339      +80     
Flag Coverage Δ
e2e 45.90% <0.00%> (-0.80%) ⬇️
integration 23.63% <0.00%> (-0.10%) ⬇️
unit 90.89% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider re-evaluating recovery token lifetimes
1 participant