Skip to content

web: Do not mark Attributes as a mandatory field #16004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dominic-r
Copy link
Contributor

Signed-off-by: Dominic R [email protected]
Closes: #15992

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@dominic-r dominic-r requested a review from a team as a code owner August 6, 2025 15:26
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 0a7f5ea
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6898070a49c0040008f94207

Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 0a7f5ea
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6898070adfb9d90008e6ac87
😎 Deploy Preview https://deploy-preview-16004--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 0a7f5ea
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6898070aea19ba00086fc608

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.66%. Comparing base (90274b3) to head (0a7f5ea).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16004      +/-   ##
==========================================
- Coverage   92.71%   92.66%   -0.05%     
==========================================
  Files         833      833              
  Lines       44731    44870     +139     
==========================================
+ Hits        41472    41580     +108     
- Misses       3259     3290      +31     
Flag Coverage Δ
e2e 45.37% <ø> (-1.33%) ⬇️
integration 23.67% <ø> (-0.06%) ⬇️
unit 90.88% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson enabled auto-merge (squash) August 6, 2025 16:23
@rissson rissson self-requested a review August 8, 2025 12:16
@rissson rissson disabled auto-merge August 8, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing mandatory attribute fields
2 participants